firebase-ios-sdk

Fix TSAN violations in FSTTransactionTests (#5922)

TSAN uncovered cases where we were reading values in the transaction
thread that were set on the main thread and were unprotected by lock. In
practice this is unlikely to cause an harm, but it's good to keep TSAN
clean for when there are real issues.