Commits
Gil authored and GitHub committed cad35b18d88
Migrate api::Firestore completions to C++ (#2831) * Make error_apple definitions out-of-line * Add util::MakeCallback Translates between API completion handlers that take just an NSError and the equivalent std::function that accepts util::Status. * Port DocumentReference::Completion to a std::function callback * Port Firestore::ErrorCompletions to StatusCallback * Port transaction-related completions to C++ * Remove now-unused FSTVoidIDErrorBlock * Fix tunneling of Firestore-generated NSErrors. Remove MakeStatus(NSError*) because it has different results from Status::FromNSError. Ensure that user-supplied errors created in transactions tunnel through correctly.